Leaves - Katie Kennedy #31
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheezItMan
reviewed
Sep 3, 2019
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
binary_to_decimal works well and you hit the major learning goals here. Check out my feedback on decimal_to_binary, and let me know if I can answer any questions.
| def binary_to_decimal(binary_array) | ||
| raise NotImplementedError | ||
| array = binary_array | ||
| power = 7 |
There was a problem hiding this comment.
Minor: I suggest making 7 a constant or using binary_array.length -1 just to make things more flexible and avoid hardcoding randomish numbers.
| #raise NotImplementedError | ||
| end | ||
|
|
||
| def decimal_to_binary(decimal_number) |
There was a problem hiding this comment.
This is actually reversing the binary digits, and your tests use numbers that read the same way backwards and forwards.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Binary and Decimal
Congratulations! You're submitting your assignment.